Feat: Identity + Fix Scalar Squeeze #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umut-sahin
force-pushed
the
feat/identity
branch
from
77617d2 to
2048566
Compare
fd0r
reviewed
Feb 2, 2024
umut-sahin
force-pushed
the
feat/identity
branch
2 times, most recently
from
966a1fa to
e2b8c7b
Compare
|
@rudy-6-4 do you think we should introduce a threshold like we did with ReLU? So that 4-bit -> 8-bit identity would be a single TLU for example? |
rudy-6-4
reviewed
Feb 5, 2024
rudy-6-4
reviewed
Feb 5, 2024
frontends/concrete-python/concrete/fhe/mlir/processors/process_rounding.py
Show resolved
Hide resolved
rudy-6-4
approved these changes
Feb 5, 2024
BourgerieQuentin
approved these changes
Feb 13, 2024
umut-sahin
force-pushed
the
feat/identity
branch
from
7227230 to
d69ecff
Compare
rudy-6-4
approved these changes
Feb 15, 2024
umut-sahin
force-pushed
the
feat/identity
branch
from
d69ecff to
8a170ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.