docs(compiler): update the doc (Part 2) [ready to be reviewed] #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcm-at-zama
commented
Mar 4, 2024
|
@rudy-6-4 @andidr : it's the PR doing what you've requested in https://github.com/zama-ai/concrete/pull/723/files, if you want to have a look |
bcm-at-zama
changed the title
bcm-at-zama
force-pushed
the
clarify_doc_part_2_622
branch
from
01d4655 to
502be80
Compare
|
Adding @BourgerieQuentin , @rudy-6-4 and @andidr as reviewers, since the changes correspond to requests they did, in particular in https://github.com/zama-ai/concrete/pull/723/files |
|
I guess I should first merge @yuxizama 's PR |
BourgerieQuentin
approved these changes
Mar 12, 2024
|
Confict, I take care of this. |
bcm-at-zama
force-pushed
the
clarify_doc_part_2_622
branch
from
502be80 to
c7e6a57
Compare
|
Rebased (was not a trivial one) |
bcm-at-zama
force-pushed
the
clarify_doc_part_2_622
branch
from
c7e6a57 to
72ca8ba
Compare
bcm-at-zama
changed the title
umut-sahin
reviewed
Mar 13, 2024
bcm-at-zama
force-pushed
the
clarify_doc_part_2_622
branch
from
72ca8ba to
571a65e
Compare
bcm-at-zama
commented
Mar 13, 2024
There was a problem hiding this comment.
Took @umut-sahin 's comments into account (thx) but the last one which will be decided by @BourgerieQuentin
|
I'm ok with you @bcm-at-zama |
|
Let me merge after #728 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up with reviews of https://github.com/zama-ai/concrete/pull/723/files
closes #https://github.com/zama-ai/concrete-internal/issues/622