Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compiler): Bump MLIR fork to version including extended canonicalization of tensor.insert_slice #836

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

andidr
Copy link
Contributor

@andidr andidr commented May 17, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label May 17, 2024
@andidr andidr force-pushed the andi/insert-slice-canonicalizer branch 2 times, most recently from 7bae75e to 8862d08 Compare May 21, 2024 09:19
@BourgerieQuentin BourgerieQuentin marked this pull request as ready for review May 27, 2024 08:43
@andidr andidr force-pushed the andi/insert-slice-canonicalizer branch 2 times, most recently from 42301ac to 570abf7 Compare June 18, 2024 12:05
@andidr
Copy link
Contributor Author

andidr commented Jun 18, 2024

@slab-ci compiler-cpu-build

andidr added 2 commits June 20, 2024 06:34
…TFHEPass

The test
`end_to_end_trace.simulate1.trace_ciphertext_without_attributes_16bits.0`
generates `Tracing.trace_ciphertext` operations, which are not handled
by `SimulateTFHEPass`, resulting in a conversion error.

This change causes `Tracing.trace_ciphertext` operations to be
converted into appropriate `Tracing.trace_plaintext` operations.
…alization of tensor.insert_slice

Also, invoke the canonicalizer to include the new canonicalization
pattern after batching in order to eliminate unnecessary copies due to
redundant insertions completely overwriting empty tensors.
@andidr andidr force-pushed the andi/insert-slice-canonicalizer branch from 570abf7 to fe20cda Compare June 20, 2024 04:40
@andidr andidr merged commit fe20cda into main Jun 20, 2024
30 of 34 checks passed
@andidr andidr deleted the andi/insert-slice-canonicalizer branch June 20, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants