refactor(frontend): improve sha1 example #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcm-at-zama
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Thx @umut-sahin . You miss to relaunch on hpc7a with a recent CP, and update the timings
|
I'm not sure how to |
|
ok I will. Blocking it for now |
|
We not yet have benchmarks from concrete-python, should we add concrete-python benchmarks? |
That can be a KR! |
BourgerieQuentin
approved these changes
Jul 4, 2024
|
Currently measuring perfs |
|
@umut-sahin , perf have been done on hpc, could you check, squash and merge please (if good with you!)? |
bcm-at-zama
approved these changes
Jul 10, 2024
umut-sahin
force-pushed
the
refactor/sha1
branch
from
ebce4f4 to
92eb9a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.