docs(frontend): 2.7x doc review #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniupop
requested changes
Jun 25, 2024
BourgerieQuentin
requested changes
Jun 25, 2024
bcm-at-zama
reviewed
Jun 25, 2024
bcm-at-zama
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Some comments. To me, it's approved for "common_errors" and for the rest, I'll let @antoniupop and @aPere3 comment on their parts.
|
When we're ok with the text, @yuxizama, don't worry we can fix the CI |
antoniupop
approved these changes
Jun 26, 2024
|
Hey guys, Thanks for the comments, they have been all addressed. Please have a look and we can move on to merge this PR. |
BourgerieQuentin
approved these changes
Jul 4, 2024
BourgerieQuentin
force-pushed
the
doc-review-2.7
branch
from
11ade81 to
5216002
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.