Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: moving tutorials in the same directory #950

Merged
merged 1 commit into from
Jul 30, 2024
Merged

docs: moving tutorials in the same directory #950

merged 1 commit into from
Jul 30, 2024

Conversation

bcm-at-zama
Copy link
Contributor

@bcm-at-zama bcm-at-zama commented Jul 22, 2024 •
edited
Loading

  • moving tutorials in the same directory
  • rename to README such that they appear in GitHub

closes #https://github.com/zama-ai/concrete-internal/issues/814
refs #https://github.com/zama-ai/concrete-internal/issues/771

@cla-bot cla-bot bot added the cla-signed label Jul 22, 2024
@bcm-at-zama bcm-at-zama requested a review from umut-sahin July 22, 2024 14:19
@bcm-at-zama bcm-at-zama force-pushed the moving_tutorials_814 branch from f3a4d22 to d5363c2 Compare July 23, 2024 08:30
@bcm-at-zama bcm-at-zama requested a review from yuxizama July 23, 2024 08:38
@bcm-at-zama bcm-at-zama changed the title Moving tutorials 814 docs: moving tutorials in the same directory Jul 23, 2024
@bcm-at-zama bcm-at-zama force-pushed the moving_tutorials_814 branch from d5363c2 to 95d48e1 Compare July 23, 2024 15:23
@bcm-at-zama
Copy link
Contributor Author

Rebasing

@bcm-at-zama
Copy link
Contributor Author

@yuxizama : for your info, I wait @umut-sahin here, to check the move is fine with him

umut-sahin
umut-sahin suggested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@umut-sahin umut-sahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two folders for key value database example with this change, we should merge them.

docs/tutorials/see-all-tutorials.md Show resolved Hide resolved
@bcm-at-zama
Copy link
Contributor Author

There are two folders for key value database example with this change, we should merge them.

Good catch, done

@bcm-at-zama bcm-at-zama force-pushed the moving_tutorials_814 branch 2 times, most recently from 228a162 to edcfde4 Compare July 30, 2024 07:48
@bcm-at-zama bcm-at-zama requested a review from umut-sahin July 30, 2024 07:50
@bcm-at-zama
Copy link
Contributor Author

bcm-at-zama commented Jul 30, 2024 •
edited
Loading

Sorry @umut-sahin my editor wants to change the .ipynb. If you want me to avoid this, I can try to use another editor No actually fixed on purpose for 95d48e1, all good

@bcm-at-zama bcm-at-zama force-pushed the moving_tutorials_814 branch from edcfde4 to 327c5d3 Compare July 30, 2024 07:54
@bcm-at-zama bcm-at-zama force-pushed the moving_tutorials_814 branch from d03b18e to a74d7aa Compare July 30, 2024 10:08
@bcm-at-zama bcm-at-zama merged commit b98ad39 into main Jul 30, 2024
9 of 12 checks passed
@bcm-at-zama bcm-at-zama deleted the moving_tutorials_814 branch July 30, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuxizama yuxizama yuxizama approved these changes

@umut-sahin umut-sahin umut-sahin approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcm-at-zama @umut-sahin @yuxizama