feat: add ConfidentialVestingWallet/ConfidentialVestingWalletCliff #76
Conversation
PacificYield
changed the title
PacificYield
changed the title
PacificYield
force-pushed
the
feat/VestingWallet.sol
branch
3 times, most recently
from
e897ec7 to
c593586
Compare
PacificYield
force-pushed
the
feat/VestingWallet.sol
branch
from
c593586 to
7212873
Compare
PacificYield
changed the title
PacificYield
force-pushed
the
feat/VestingWallet.sol
branch
3 times, most recently
from
f9e27fd to
7501cdb
Compare
|
I prefer let @jatZama review it 🙏 |
PacificYield
force-pushed
the
feat/VestingWallet.sol
branch
from
7501cdb to
e536334
Compare
| */ | ||
| abstract contract ConfidentialVestingWallet { | ||
| /// @notice Emitted when tokens are released to the beneficiary address. | ||
| event ConfidentialERC20Released(); |
There was a problem hiding this comment.
why you didn't keep original OZ specs allowing different tokens? this event should then contain an address argument. It is always better to make standard contracts as generalizable as possible imo.
| event ConfidentialERC20Released(); | ||
|
|
||
| /// @notice Beneficiary address. | ||
| address public immutable BENEFICIARY; |
There was a problem hiding this comment.
same here, not sure why you didnt keep OZ's specs with a modifiable owner.
There was a problem hiding this comment.
ok for this one I understand because of ACL, yo can keep it immutable then maybe
| IConfidentialERC20 public immutable CONFIDENTIAL_ERC20; | ||
|
|
||
| /// @notice Duration (in seconds). | ||
| uint64 public immutable DURATION; |
There was a problem hiding this comment.
can you instead keep OZ's specs, with private variable and public getter functions?
| } else if (timestamp >= END_TIMESTAMP) { | ||
| return totalAllocation; | ||
| } else { | ||
| return TFHE.div(TFHE.mul(totalAllocation, (timestamp - START_TIMESTAMP)), DURATION); |
There was a problem hiding this comment.
Warning: there is a critical risk in case of overflow here, you should cast the totalAllocation to an euint128 before doing the product this is very important
This PR adds two Solidity contracts:
ConfidentialVestingWallet.solandConfidentialVestingWalletCliff.sol.