Fix static linking on Mac #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dartdart26
reviewed
Oct 20, 2023
|
|
||
| .PHONY: build-tfhe-rs-capi | ||
| build-tfhe-rs-capi: | ||
| cd tfhe-rs && make build_c_api_experimental_deterministic_fft | ||
| cd tfhe-rs && make build_c_api_experimental_deterministic_fft \ | ||
| && cd target/release && rm -f *.dylib *.dll *.so |
There was a problem hiding this comment.
Why do we need to rm here?
There was a problem hiding this comment.
Sorry, I saw the description. Wouldn't it work even if we don't remove?
There was a problem hiding this comment.
By default linker prefers dynamic libraries if they are available, now we specify tfhe lib with -ltfhe flag, which doesn't imply if it is static or dynamic, so if we remove dynamic libraries, linker is forced to link statically
There was a problem hiding this comment.
It would work, but then on macbook it links dynamically, I tried -l:libtfhe.a flag but it doesn't work
dartdart26
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-framework Securityflag was missing, when building subnet-evm this flag seems to be added automatically as build works.We remove all dynamic library builds to make sure only static library is linked by the next build step.