add remaining ops to the fhelib precompile #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-zk
approved these changes
Oct 24, 2023
fhevm/crypto.go
Outdated
|
|
||
| // CreateProtectedStorageAddress creates an ethereum contract address for protected storage | ||
| // given the corresponding contract address | ||
| func CreateProtectedStorageContractAddress(b common.Address) common.Address { |
There was a problem hiding this comment.
Nit: to have less files I'd put this standalone function in evm.go that contains the utility functions of our precompiles
There was a problem hiding this comment.
I can move it yeah. Reading Petar's PR here I also find that he makes a reference to fhevm-go/crypto while I don't think it's available right now, right? Would this solve it?
There was a problem hiding this comment.
oh my bad, it already exists! I will update the PR
youben11
force-pushed
the
feat/add-precompiles
branch
from
8ac5b61
to
54d04b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14