Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support different way to init global keys #20

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat: support different way to init global keys #20

merged 1 commit into from
Oct 30, 2023

Conversation

youben11
Copy link
Member

No description provided.

dartdart26
dartdart26 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@dartdart26 dartdart26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

fhevm/tfhe.go Outdated Show resolved Hide resolved
@youben11 youben11 mentioned this pull request Oct 27, 2023
Open
@youben11
feat: support different way to init global keys
a8f6dd3 
still not ideal. Keys are still loaded from files, or generated on the
go during tests.
@dartdart26 dartdart26 merged commit 2e576f2 into main Oct 30, 2023
1 check passed
@dartdart26 dartdart26 deleted the feat/keys branch October 30, 2023 15:43
@youben11 youben11 mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dartdart26 dartdart26 dartdart26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youben11 @dartdart26