feat: add clean interpreter.Run integration function #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something to consider: I had an import cycle in ethermint because of this |
|
@youben11 Do you still want to merge it? |
I wasn't quite happy with the final result of it as it became much more dependent of geth, and I don't think it's a good idea to merge. Do you have an opinion on this? |
Cool, let's close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After ethereum/go-ethereum#28633, I realized we can have a clean integration function for
interpreter.Run, without requiring integrators to modify the inner function with branching, but to only call our own implementation.This PR however, makes fhevm-go more dependent of geth, which is something we may not want to have, so we may not want to merge it at the end.