Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/refactor #95

Merged
merged 9 commits into from
Mar 5, 2024
Merged

Chore/refactor #95

merged 9 commits into from
Mar 5, 2024

Conversation

immortal-tofu
Copy link
Contributor

No description provided.

Copy link
Member

@youben11 youben11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new structure, but maybe having a second review from @dartdart26 who is more experienced in Go would be beneficial.

Another thing that would be necessary to do is to check for changes that may impact other libs depending on fhevm-go. This can be done by integrating the new version into ethermint. This will also put the light on the different changes we need to make to the Integration page in the docs to make sure it's up to date.

Makefile Outdated Show resolved Hide resolved
@youben11 youben11 requested a review from dartdart26 March 5, 2024 11:04
@immortal-tofu
Copy link
Contributor Author

I like the new structure, but maybe having a second review from @dartdart26 who is more experienced in Go would be beneficial.

Another thing that would be necessary to do is to check for changes that may impact other libs depending on fhevm-go. This can be done by integrating the new version into ethermint. This will also put the light on the different changes we need to make to the Integration page in the docs to make sure it's up to date.

I changed the folder structure to keep fhevm package name. With this modification, zbc-ethermint still works with no changes. See https://github.com/zama-ai/zbc-ethermint/actions/runs/8158219742/job/22299638534

@immortal-tofu immortal-tofu merged commit 1df5200 into main Mar 5, 2024
2 checks passed
@immortal-tofu immortal-tofu deleted the chore/refactor branch March 5, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants