refactor: remove optReq #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E tests are failing https://github.com/zama-ai/zbc-ethermint/actions/runs/8205081878/job/22441159247 |
|
The integration docs also reference some of these functions, so a change there is also necessary |
immortal-tofu
force-pushed
the
refactor/remove-optreq
branch
from
52ce1a6
to
00d0c34
Compare
|
@youben11 Docs has been updated, tests are passing, a PR is open on zbc-go-ethereum. |
youben11
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to merge the refactor of go-ethereum zama-ai/zbc-go-ethereum#10
Tests are running (with fhevm-go branch and go-ethereum branch) https://github.com/zama-ai/zbc-ethermint/actions/runs/8210782726/job/22459527138