Fhevmjs fixes to work with local node #70
Conversation
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @david-zk on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @david-zk on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
| data.set(ciphertext, data.length + 1); | ||
| data.set([bits.length], 0); | ||
| bits.forEach((value, index) => { | ||
| data.set([ENCRYPTION_TYPES[value] & 0xff], 1 + index); |
There was a problem hiding this comment.
ENCRYPTION_TYPES[value] should never exceed 255 from definition already
There was a problem hiding this comment.
The value in that map is of type number which has a big range. I'm not sure how to best approach this, ideally this should be a compile time error, if someone adds a larger number things will "work" but write bad values.
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @david-zk on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
|
@david-zk when I said |
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @david-zk on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success26 tests passing in 6 suites. Report generated by 🧪jest coverage report action from 0213255 |
Tested with coprocessor, we need following adjustments:
0xin front of input hex string to be sent as input payloadAdded draft test with getting public key and encoding inputs, I think we might need to setup running container of the service to test the integration.
@immortal-tofu @jatZama