Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all available FHE ops #120

Merged
merged 8 commits into from
Jun 26, 2023
Merged

Conversation

tremblaythibaultl
Copy link
Contributor

Closes #111

@tremblaythibaultl tremblaythibaultl self-assigned this Jun 22, 2023
@tremblaythibaultl tremblaythibaultl marked this pull request as draft June 22, 2023 07:57
@tremblaythibaultl tremblaythibaultl changed the title feat(tfhe): add all available FHE ops Add all available FHE ops Jun 22, 2023
@tremblaythibaultl
Copy link
Contributor Author

There is a lot of code duplication here. As discussed in #122, our precompile system is due for refactoring which is left as future work.

@tremblaythibaultl tremblaythibaultl marked this pull request as ready for review June 22, 2023 11:33
Copy link
Collaborator

@dartdart26 dartdart26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

}

resultHash := result.getHash()
logger.Info("fheGt success", "lhs", lhs.ciphertext.getHash().Hex(), "rhs", rhs.ciphertext.getHash().Hex(), "result", resultHash.Hex())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: fheGe

@tremblaythibaultl tremblaythibaultl merged commit e1a6156 into 1.10.19-zama Jun 26, 2023
@tremblaythibaultl tremblaythibaultl deleted the louis/complete-fhe-ops branch July 11, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(geth): add missing FHE ops
2 participants