Add fheLib precompile with first fheAdd method #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case 0xf953e427: | ||
| bwCompatBytes := input[4:minInt(69, len(input))] | ||
| // state of fheAdd struct is never needed or accessed so we use nil | ||
| return (*fheAdd)(nil).Run(accessibleState, caller, addr, bwCompatBytes, readOnly) |
There was a problem hiding this comment.
Nice, I didn't know about this
There was a problem hiding this comment.
This is static dispatch so in theory should be faster
core/vm/contracts_test.go
Outdated
| isScalarByte = 0 | ||
| } | ||
| ret = append(ret, isScalarByte) | ||
| // padding |
There was a problem hiding this comment.
Would something like
padding = make([]byte, 31)
ret = append(ret, padding...)
be better?
There was a problem hiding this comment.
@tremblaythibaultl yeah, we could do that, I was just paranoid about extra allocation for padding array but I hope compiler is smart enough these days to detect this. I added this to dfc0040 commit, padding is allocated only once as static variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fhe library precompiled, only with one method now.
I reuse code of current precompiles and just pass subslice of the previous solidity abi call convention to the existing precompile so everything works.
@tremblaythibaultl @dartdart26