feat(vm): add remainder precompile #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
youben11
commented
Oct 4, 2023
youben11
commented
- support remainder as an independent precompile
- support remainder through the fhelib precompile
- still need to confirm the amount of gas
dartdart26
approved these changes
Oct 5, 2023
Comment on lines
+3226
to
+3229
| func TestFheLibRem8(t *testing.T) { | ||
| FheLibRem(t, FheUint8, true) | ||
| } | ||
|
|
There was a problem hiding this comment.
Is there a particular reason why we test 8 bit only for FheLibRem? I am just posting it here, but it is not related to this PR. I guess we will remove non-lib tests at some point.
There was a problem hiding this comment.
I mainly followed tests for div. I can add more in the current PR, or make another PR to go through all the tests and add 16 and 32 bits tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.