Ns/bench zk cs ghl #1825
Merged
Ns/bench zk cs ghl #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
manual run of the bench workflow: https://github.com/zama-ai/tfhe-rs/actions/runs/12033323684/job/33547332621 |
nsarlin-zama
force-pushed
the
ns/bench_zk_cs_ghl
branch
from
3ea5bf7
to
bb3529f
Compare
IceTDrinker
reviewed
Nov 27, 2024
| ComputeLoad::Verify => "compute_load_verify", | ||
| }; | ||
| let bench_id = format!("{bench_name}::{param_name}_{bits}_bits_packed_{zk_load}"); | ||
| let bench_id = format!("{bench_name}::{param_name}_{bits}_bits_packed_{load}_{bound:?}"); |
There was a problem hiding this comment.
debug formatting of bounds is ok for our format ?
There was a problem hiding this comment.
It will print "GHL" or "CS", which is ok as David confirmed
tfhe-zk-pok/benches/utils.rs
Outdated
Comment on lines
462
to
465
| #[allow(unused)] | ||
| pub fn init_params_v2_ghl( | ||
| test_params: PkeTestParameters, | ||
| ) -> ( |
There was a problem hiding this comment.
could be a single function taking the bound kind and then match in there, otherwise the caller needs to know how this works
IceTDrinker
reviewed
Nov 27, 2024
tfhe-zk-pok/src/proofs/pke_v2.rs
Outdated
| }) | ||
| .checked_mul(B_squared + (sqr((d + 2) as u128) * (d + k) as u128) / 4) | ||
| .unwrap_or_else(|| { | ||
| panic!("Invalid parameters for zk_pok, B_squared: {B_squared}, d: {d}, k: {k}") |
There was a problem hiding this comment.
a clearer error message please
tfhe-zk-pok/src/proofs/pke_v2.rs
Outdated
| // safely used for this | ||
| assert!( | ||
| m_bound <= 64, | ||
| "Invalid parameters for zk_pok, B_squared: {B_squared}, d: {d}, k: {k}, m_bound: {m_bound} > 64" |
There was a problem hiding this comment.
same here for the m_bound could be "we only support 64 bits integer, the computed m parameter is {m_bound} bits > 64 bits"
nsarlin-zama
force-pushed
the
ns/zk_test_bad_delta
branch
from
ae567f8
to
d5838e0
Compare
nsarlin-zama
force-pushed
the
ns/bench_zk_cs_ghl
branch
2 times, most recently
from
8efd842
to
41cdebe
Compare
IceTDrinker
approved these changes
Nov 29, 2024
nsarlin-zama
force-pushed
the
ns/bench_zk_cs_ghl
branch
from
41cdebe
to
38c731f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR content/description
Adds a bench to compare ghl and cs bounds for zk v2. Also add some limit tests for zk with extreme but supported values