Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix server_endpoint crash on connection failure #553

Merged
merged 2 commits into from
Jun 9, 2016
Merged

Fix server_endpoint crash on connection failure #553

merged 2 commits into from
Jun 9, 2016

Conversation

yeswalrus
Copy link
Contributor

Fixes #551

@zaphoyd
Copy link
Owner

zaphoyd commented May 19, 2016

unless I am mistaken, removing ec = lib::error_code(); means a successful call will leave ec at its initial value rather than setting to 0 (the code for success).

@yeswalrus
Copy link
Contributor Author

Quite so. Fixed.

@zaphoyd zaphoyd added the Core label Jun 9, 2016
@zaphoyd zaphoyd merged commit 6b09310 into zaphoyd:develop Jun 9, 2016
@zaphoyd zaphoyd mentioned this pull request Jun 9, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeswalrus @zaphoyd