-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace make_shared with new in some cases #810
Conversation
Update version number in CMakeLists.txt to 0.8.1
Replace make_shared for asio types that take a lib::ref as a parameter. This should fix the ASIO change (boostorg/asio@59066d8) for 1.70, while keeping it backwards compatible to older boost versions.
When building against boost 1.70, our team still had issues with the lib::ref on endpoint.hpp line 856. Removing the lib::ref allowed it to compile for us. Here is what we changed it to. |
Sorry, missed to add those. Should be fixed now. For the reasoning between |
I cite the linked comment:
|
Is there any progress on this getting merged? |
What stops this from being merged? |
@zaphoyd Could you please merge this PR and make a release? Thank you, |
Can you open this against the develop branch? |
see #814 |
wow, awesome!!! I've waste hours to fix this problem until I saw your commit |
Replace make_shared for asio types that take a lib::ref as a parameter.
This should fix the ASIO change (boostorg/asio@59066d8) for 1.70,
while keeping it backwards compatible to older boost versions.
Fixes #794
Fixes #808