Never use root logger to allow filtering zappa logs with greater ease #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkut
approved these changes
Oct 19, 2023
|
I think the CI failed independently of my MR, should I do something @monkut? |
|
Ping @monkut? |
javulticat
approved these changes
Nov 6, 2023
|
Hey @bagage, I came across this today, and it looked like the CI runners indeed had experienced some unrelated issue the first time they ran for your PR and you just needed someone to re-run the CI jobs for you. So, I triggered the CI to run on your PR again, and everything came back green as expected. So, I went ahead and merged this after giving the code a quick review myself. Nice catch, and thanks for your contribution! |
|
Awesome, thanks @javulticat 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is a simple change to avoid using the root logger, so that upstream application can easily decide how to handle these specific logs while leaving root logger untouched.
GitHub Issues