Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] oast/ascanrulesAlpha: Add LDAP Support #3665

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cauan-ti
Copy link

Added LDAP support to OAST Interactsh Addon

Log4shell Rules, Added the OAST token in the search query, Allowing ZAP to identify LDAP interactions.

@thc202 thc202 changed the title OAST Ldap Support oast: Add LDAP Support Mar 16, 2022
@thc202 thc202 changed the title oast: Add LDAP Support oast/ascanrulesAlpha: Add LDAP Support Mar 16, 2022
@thc202
Copy link
Member

thc202 commented Mar 16, 2022

Please see https://github.com/zaproxy/zap-extensions/pull/3665/checks?check_run_id=5565672113

Be good to add tests.
The changelogs need to be updated.

Signed-off-by: Cauan Guimarães <cauan@threatintelligence.com>
Signed-off-by: Cauan Guimarães <cauan@threatintelligence.com>
@thc202 thc202 changed the title oast/ascanrulesAlpha: Add LDAP Support [WIP] oast/ascanrulesAlpha: Add LDAP Support Mar 17, 2022
@psiinon psiinon requested a review from ricekot March 22, 2022 17:06
@kingthorin
Copy link
Member

Ping @cauan-ti do you plan to finish this?

@kingthorin kingthorin added the waiting-for:pr-author This PR is currently waiting for input or changes from the original submitter label Sep 11, 2022
@kingthorin
Copy link
Member

@cauan-ti do you plan to finish this?

@ArkaprabhaChakraborty
Copy link
Contributor

What does this PR need to be completed? tests and "?"... more code? I can pick this up from where @cauan-ti left it....

@kingthorin
Copy link
Member

kingthorin commented May 4, 2023

Conflict addressed.
CHANGELOG entry.
Tests.
Help update.

Thats what I see looking quickly.

@ArkaprabhaChakraborty
Copy link
Contributor

Will make the update! [pentesting job is becoming pain-testing day by day :)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for:pr-author This PR is currently waiting for input or changes from the original submitter
Development

Successfully merging this pull request may close these issues.

4 participants