-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 WIP Integrate parcel and refactor to more pure Vue components #459
Draft
jaywon
wants to merge
39
commits into
zaproxy:develop
Choose a base branch
from
jaywon:chore/integrate-parcel
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
ae69a91
Add parcel dependencies and run tasks
jaywon ed7270d
Convert custom environment parsing syntax for Post HTML syntax for va…
jaywon 171e11f
Add parcel specific files/directories to .gitignore
jaywon c5174b1
Add .env example file to repo for self-documenting vars
jaywon b8e81e8
Merge branch 'develop' into chore/integrate-parcel
jaywon c1a52c0
:pencil2: Add .vscode directory to .gitignore
jaywon 66d434b
:recycle: Create shared module for Vue EventBus singleton
jaywon e2ccd3c
Add global SCSS for starting to theme the application
jaywon c2d828f
:recycle: Refactor panel files into standard Vue Single File Component
jaywon 3bff06d
:recycle: Refactor management pane to Vue Single File Component
jaywon a595939
:wrench: Add parcel build/run statements to watch entrypoints directory
jaywon 3c72d1d
:heavy_plus_sign: Add Display components for migration/refactor
jaywon 034d987
:fire: Delete display.css, migrated to Vue Display component
jaywon 4394ae1
:recycle: Break out HudButton and HudButtons to their own components
jaywon 7d4c1a8
:recycle: Break out Tab and Tabs to their own components
jaywon 6ed9e7a
:recycle: Break out AlertAccordion to its own component
jaywon 10b9211
:recycle: Refactor all modals into their own components
jaywon 1ba51e7
:recycle: Break out ToolListItem to its own component
jaywon c99dd70
:recycle: Break out SiteTreeNode to its own component
jaywon 5f1e77a
Uncomment Spectre css include for now, will evaluate spectre componen…
jaywon bb29d06
:recycle: Refactor display.html|css|js to a Vue Single Page Component…
jaywon f71b2be
:recycle: Refactor management.html|css|js to a Vue Single Page Compon…
jaywon 8494797
:recycle: Stub out Drawer Single Page Component files for conversion
jaywon 8b5ffe8
:fire: Remove manual vue dependencies in favor of parcel build from n…
jaywon 641de54
:heavy_plus_sign: Add localforage import
jaywon 165abc6
:recycle: Remove localforage script tag and clean up cruft
jaywon d8dcca3
Add TODO note for refactor
jaywon bcde54e
:recycle: Remove localforage script include and use ES6 import
jaywon 440ea17
Add i18n compiled file to development environment since it's needed f…
jaywon 098534d
:wrench: Change PostHTML delimiters to not conflict with Vue template…
jaywon 74ee6d7
Refactor i18n interpolation and PostHTML delimiter syntax
jaywon 7b8308d
:fire: Remove webpack dependencies and configuration
jaywon e9e34a1
:fire: Remove localforage downloaded copy for npm version
jaywon 622c5da
:recycle: Convert display into entrypoint and associated files for ne…
jaywon 47a4cad
:sparkles: Linter reformatting and minor cleanup
jaywon bbf848a
Add placeholder main file to start holding global styles
jaywon d795df9
:recycle: Conversion of all drawer related component
jaywon 3dac5ee
:pencil2: Fix default locale in i18n init
jaywon 1a327d3
:heavy_plus_sign: :heavy_minus_sign} Update node packages
jaywon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| import Vue from 'vue'; | ||
| export const EventBus = new Vue(); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love this shared module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the events are registered in this external bus, they all need to be individually torn down:
e.g.
You could create a global mixin here, but I think that the difficulty you would face is that you will have to contort yourself to know which component is being destroyed. Probably better to tear them down in the individual components, because that way later contributors can SEE that they are being unregistered.