Access files by path instead of query #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psiinon
force-pushed
the
feature/pathchange
branch
from
057681d
to
62af9c3
Compare
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
psiinon
force-pushed
the
feature/pathchange
branch
from
62af9c3
to
23b2778
Compare
thc202
approved these changes
Aug 2, 2019
jaywon
approved these changes
Aug 6, 2019
There was a problem hiding this comment.
YES!! This is awesome, thank you so much for doing that. Best I can foresee, this should solve the requirements for refactoring the frontend via referenced PR. 🙇 🎉
Made one small comment, not sure if it's a blocker or not, but approving anyhow as I'd love to get this into develop functionally and re-evaluate how to get the PR merged in.
| // Currently only javascript files are returned | ||
| msg.setResponseHeader( | ||
| API.getDefaultResponseHeader( | ||
| "application/javascript; charset=UTF-8", |
There was a problem hiding this comment.
Should this have a little more evaluation on file type for setting the header since we'll be serving CSS and image files as well?
There was a problem hiding this comment.
Those will be served by HudFileProxy which does that.
|
So exciting!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've not updated the changelog as this is an 'internal' change to support #459
URLs used by the HUD to request files and images will now have formats like:
https://zap//zapCallBackUrl/<random number>/file/panel.htmlhttps://zap//zapCallBackUrl/<random number>/image/target-grey.pngSigned-off-by: Simon Bennetts psiinon@gmail.com