Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cobra zsh gen #313

Closed
wants to merge 4 commits into from
Closed

Use cobra zsh gen #313

wants to merge 4 commits into from

Conversation

rsteube
Copy link
Collaborator

@rsteube rsteube commented Jun 5, 2019

Sadly the PR concerning zsh completion is still not merged yet, but i managed to extract the changes to a separate package.
This way lab does not need to depend on a cobra fork anymore but instead just has to add an additional dependency (https://github.com/rsteube/cobra-zsh-gen).

Copy link
Owner

@zaquestion zaquestion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch!

@rsteube
Copy link
Collaborator Author

rsteube commented Jun 12, 2019

The zsh PR is now merged. Opened a new PR for the custom completions.
If that succeeds soon we might as well switch directly to the new version and skip this PR.

@zaquestion
Copy link
Owner

Just seeing this, sounds good, LMK what route you wanna take and we'll do that.

@rsteube
Copy link
Collaborator Author

rsteube commented Jul 6, 2019

Let's be optimistic for now.

@rsteube
Copy link
Collaborator Author

rsteube commented Sep 26, 2019

@zaquestion In the light of spf13/cobra#959 i unarchived https://github.com/rsteube/cobra-zsh-gen and think we should reopen this PR.

Have a look at the go.mod, i executed go mod tidy and it seems quite some entries were removed by that.

@zaquestion
Copy link
Owner

zaquestion commented Oct 9, 2019

@rsteube Feel free to reopen (I think you'll need to open new), as long as you merge/rebase in master and do a build with modules enabled it should resolve how the go.mod works out.

At least it won't let me reopen as it says the branch has been force pushed (so if you already rebased or some such thats probably why)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants