-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cobra zsh gen #313
Use cobra zsh gen #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice touch!
The zsh PR is now merged. Opened a new PR for the custom completions. |
Just seeing this, sounds good, LMK what route you wanna take and we'll do that. |
Let's be optimistic for now. |
@zaquestion In the light of spf13/cobra#959 i unarchived https://github.com/rsteube/cobra-zsh-gen and think we should reopen this PR. Have a look at the |
@rsteube Feel free to reopen (I think you'll need to open new), as long as you merge/rebase in master and do a build with modules enabled it should resolve how the At least it won't let me reopen as it says the branch has been force pushed (so if you already rebased or some such thats probably why) |
Sadly the PR concerning zsh completion is still not merged yet, but i managed to extract the changes to a separate package.
This way lab does not need to depend on a cobra fork anymore but instead just has to add an additional dependency (https://github.com/rsteube/cobra-zsh-gen).