Skip to content

Commit

Permalink
Expose PVC accessMode as variable (#1664)
Browse files Browse the repository at this point in the history
## Description

When attempting to upgrade our EKS Node AMIs in AWS, we noticed that the
Zarf Registry deployment was unable to horizontally scale across nodes
which needed to restart. We believe the culprit is the `accessMode`
specification for the PersistentVolumeController. In order for multiple
pods to have access to the same PersistentVolume, the `accessMode` must
be set to "ReadWriteMany".

~~This PR proposes that when autoscaling is enabled for the Zarf
Registry, the `accessMode` is set to "ReadWriteMany" by default; when
autoscaling is disabled, it is set to "ReadWriteOnce". Due to the
additional work required (i.e. using an existing
PersistencVolumeController with a storage class compatible with RWX), we
also propose that `autoscaling` be disabled by default.~~

This PR exposes the `REGISTRY_PVC_ACCESS_MODE` variable for the
`zarf-registry` portion of the init package.

## Related Issue

- Relates to #375 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed
  • Loading branch information
willswire authored May 8, 2023
1 parent 191e6f2 commit 2a5adf2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions packages/zarf-registry/registry-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ persistence:
storageClass: "###ZARF_STORAGE_CLASS###"
size: "###ZARF_VAR_REGISTRY_PVC_SIZE###"
existingClaim: "###ZARF_VAR_REGISTRY_EXISTING_PVC###"
accessMode: "###ZARF_VAR_REGISTRY_PVC_ACCESS_MODE###"

image:
repository: "###ZARF_REGISTRY###/###ZARF_CONST_REGISTRY_IMAGE###"
Expand Down
4 changes: 4 additions & 0 deletions packages/zarf-registry/zarf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ variables:
description: "The size of the persistent volume claim for the registry"
default: "20Gi"

- name: REGISTRY_PVC_ACCESS_MODE
description: "The access mode of the persistent volume claim for the registry"
default: "ReadWriteOnce"

- name: REGISTRY_CPU_REQ
description: "The CPU request for the registry"
default: "100m"
Expand Down

0 comments on commit 2a5adf2

Please sign in to comment.