Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update find-images output to contain the images' digest #2327

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

waveywaves
Copy link
Contributor

@waveywaves waveywaves commented Feb 22, 2024

Description

update find-images output to contain the images' digest

Related Issue

Fixes #2247

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit c864287
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/65e90a44a1f1fa0008bec8e0

imageWithSha, err := utils.GetImageWithSha(image)
if err != nil {
message.WarnErrf(err, "Problem getting image with sha for %s: %s", image, err.Error())
erroredCosignLookups = append(erroredCosignLookups, image)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosign signatures are different than sha signatures. I recommend creating a new array for erroredShaLookups. You can place a message near erroredCosginLookups in the below block further down in the file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a check with erroredShaLookups

src/pkg/utils/image.go Outdated Show resolved Hide resolved
src/pkg/packager/prepare.go Outdated Show resolved Hide resolved
@waveywaves waveywaves marked this pull request as draft March 5, 2024 10:57
@waveywaves waveywaves marked this pull request as ready for review March 7, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

During zarf dev find-images automatically add the digest to any tag to help with pinning resources
2 participants