feat: migrate package create to slog #3132
Merged
+458
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
mkcp
changed the title
mkcp
force-pushed
the
mkcp/slog-package-create
branch
2 times, most recently
from
e7052c4
to
5fbe641
Compare
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
…ng away from message on package create Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
…sole-slog and console format Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
mkcp
force-pushed
the
mkcp/slog-package-create
branch
from
3e3c88f
to
7b387e8
Compare
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
|
You will need to edit cmd.Execute to slog an error message |
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
|
Revisions applied - should be good to go. Just waiting on ci checks. |
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
AustinAbro321
approved these changes
Oct 25, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
sloglintdevslog(via--log-format="dev") andconsole-slog(via--log-format="console")packager.Packagerand stores a context on it so we can log in its New() which has some load bearing logging. This is intended as a workaround.--log-format=""== "none. So slog must be directly enabled.cmd/rootand feature flagging for disabling message and using logger.setupMessage()ensures PTerm output is discarded and sets the values for--no-progress, and--confirm.zarf package createRelated Issue
Relates to #2576
Checklist before merging