Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default chunks fix #28

Merged
merged 10 commits into from
Mar 20, 2024
Merged

Default chunks fix #28

merged 10 commits into from
Mar 20, 2024

Conversation

d-v-b
Copy link
Collaborator

@d-v-b d-v-b commented Mar 19, 2024

a few changes in here
docs:

  • improve some prose in the docs
  • fix a broken link in docs

ArraySpec.from_array

  • When chunks is not "auto", use guess_chunks from zarr-python instead of defaulting to a single chunk. A single chunk is completely wrong for large arrays.
  • expand the function signature of from_array to explicitly list the parameters, and make each one default to "auto", which dispatches to functions that attempt to infer an attribute value from the input data. So an array with an attrs attribute will have the attrs propagate to the resulting ArraySpec.

to_zarr

  • make overwrite an explicit keyword-only argument

support for python 3.9

  • import TypeAlias from typing_extensions
  • add some little pydantic dependency that enables the modern union | operator

@d-v-b d-v-b mentioned this pull request Mar 19, 2024
@d-v-b d-v-b merged commit 0b423c3 into main Mar 20, 2024
5 checks passed
@d-v-b d-v-b deleted the default_chunks_fix branch March 20, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant