Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fieldfriend without Bumper #240

Closed
Johannes-Thiel opened this issue Nov 29, 2024 · 0 comments · Fixed by #241
Closed

Fieldfriend without Bumper #240

Johannes-Thiel opened this issue Nov 29, 2024 · 0 comments · Fixed by #241

Comments

@Johannes-Thiel
Copy link
Contributor

When a fieldfriend without a bumper is used, there will be following error

rosys_1       | AssertionError
rosys_1       | 2024-11-29 11:46:07.244 [ERROR] rosys/rosys.py:165: error in "AutomationWatcher.try_resume"
rosys_1       | Traceback (most recent call last):
rosys_1       |   File "/home/zauberzeug/.local/lib/python3.11/site-packages/rosys/rosys.py", line 159, in _repeat
rosys_1       |     await invoke(self.handler)
rosys_1       |   File "/home/zauberzeug/.local/lib/python3.11/site-packages/rosys/helpers/__init__.py", line 35, in invoke
rosys_1       |     result = handler(*args)
rosys_1       |              ^^^^^^^^^^^^^^
rosys_1       |   File "/app/field_friend/automations/automation_watcher.py", line 90, in try_resume
rosys_1       |     assert self.field_friend.bumper is not None

This is due to the check in

field_friend/field_friend/automations/automation_watcher.py

Line 90 in 3409ff2

assert self.field_friend.bumper is not None

We should rewrite it so we can have fieldfreinds without bumper.
@LukasBaecker LukasBaecker mentioned this issue Nov 29, 2024
Merged
@LukasBaecker LukasBaecker linked a pull request Nov 29, 2024 that will close this issue
No Bumper Handling #241
Merged
LukasBaecker added a commit that referenced this issue Nov 29, 2024
@LukasBaecker
No Bumper Handling (#241)
e5094d0 
When the robot has no bumper the automation_watch will throw an
assertion as you can see in Issue #240. There are Fieldfriends that do
not have bumpers at all. That is why we need an appropriate handling of
it in the automation_watch. We would like to log a warning in case a
robot with bumpers has an error or disconnected bumpers but beside that
we just deactivate the bumper watcher.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

No Bumper Handling zauberzeug/field_friend
1 participant
@Johannes-Thiel