Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing closed-loop stepper motor alarm (for U4) #113

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

LukasBaecker
Copy link
Contributor

@LukasBaecker LukasBaecker commented Jul 9, 2024

Due to the fact that U4 with Tornado has the only closed-loop stepper motor which is not adressed with CAN as later stepper motors. A fix for the internal alarm is necessary.

  • Creating quick fix for U4
  • Fixing the invert of the alarm with use of config file to set the hardware when setting up the robot.
  • Test on U4
  • Test on other robot (should not have an influence)

Test steps:

  • Deploy code without updating the config. It should raise a KeyError
  • Update the config
  • Drive and reference the robot

@LukasBaecker LukasBaecker changed the title quick fix for U4 y-axis alarm fixing closed-loop stepper motor alarm (for U4) Jul 9, 2024
@pascalzauberzeug pascalzauberzeug added this to the 0.2.0 milestone Jul 11, 2024
@pascalzauberzeug pascalzauberzeug added the bug Something isn't working label Jul 11, 2024
@pascalzauberzeug
Copy link
Contributor

As expected F13/RB36 runs without any errors

@pascalzauberzeug pascalzauberzeug marked this pull request as ready for review July 17, 2024 12:30
@pascalzauberzeug
Copy link
Contributor

This must be tested on U4 and until then U4 must not be newly configured!

Copy link
Contributor Author

@LukasBaecker LukasBaecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the small changes on the error message, your changes look good @pascalzauberzeug
Already tested the changes on U4. Worked.

field_friend/hardware/field_friend_hardware.py Outdated Show resolved Hide resolved
@LukasBaecker LukasBaecker merged commit 13b5238 into main Jul 24, 2024
1 check passed
@LukasBaecker LukasBaecker deleted the closed-loop-stepper-motor branch July 24, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants