Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Punch demo #143

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Punch demo #143

merged 3 commits into from
Jul 30, 2024

Conversation

rodja
Copy link
Member

@rodja rodja commented Jul 30, 2024

Provide a checkbox to run tornado in demo mode (eg. stop before the ground).

@rodja rodja added the enhancement New feature or request label Jul 30, 2024
@rodja rodja added this to the 0.3.0 milestone Jul 30, 2024
@rodja rodja requested a review from pascalzauberzeug July 30, 2024 04:23
pascalzauberzeug
pascalzauberzeug reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@pascalzauberzeug pascalzauberzeug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only merge this with a feature request for all weeding implements and a setting in the robot config for the demo height

field_friend/automations/puncher.py Show resolved Hide resolved
field_friend/automations/implements/tornado.py Show resolved Hide resolved
@pascalzauberzeug
Copy link
Contributor

We talked about this: I will merge this PR and created a feature requests for the other tools and concerns.

@pascalzauberzeug pascalzauberzeug modified the milestones: 0.3.0, 0.2.0 Jul 30, 2024
@pascalzauberzeug pascalzauberzeug merged commit 58a7354 into main Jul 30, 2024
3 checks passed
@pascalzauberzeug pascalzauberzeug deleted the punch-demo branch July 30, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalzauberzeug pascalzauberzeug pascalzauberzeug left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rodja @pascalzauberzeug