Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mode_indicator of GNS instead of the gps_qual from GGA sentence #150

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

LukasBaecker
Copy link
Contributor

@LukasBaecker LukasBaecker commented Aug 8, 2024

The GNSS module sends information formatted along the NMEA-0183 standard. We are currently using the Lat/Lon position from the GNS message which contains GNSS data. For data quality checks we are further using the gps_qual of the GGA massage which only refers to GPS. The mode_indicator of the GNS message contains the mode of every single satellite system.

Todo:

  • use the mode_indicator instead of the gps_qual
  • check, if it is enough if a single satellite system gives RTK fixed data (e.g. mode: 'RNNN) or if all need to be fixes (mode: 'RRRR') to get RTX-fixed LatLon positions
  • test on a robot

@LukasBaecker LukasBaecker added this to the 0.3.0 milestone Aug 8, 2024
@LukasBaecker LukasBaecker marked this pull request as ready for review August 13, 2024 11:29
Copy link
Contributor

@angelom93 angelom93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice!

@angelom93 angelom93 merged commit a8210e6 into main Aug 14, 2024
1 check passed
@angelom93 angelom93 deleted the gnss_quality_message branch August 14, 2024 08:55
@LukasBaecker LukasBaecker mentioned this pull request Aug 15, 2024
@pascalzauberzeug pascalzauberzeug added the enhancement New feature or request label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants