field_provider.py mutable default argument #187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
in the FieldProvider class, there are multiple instances of mutable default arguments.
I have observed, that when using the FieldFriend and creating a field, adding more than one row results in the rows sharing the same points until restarted.
The root cause are mutable default arguments (the list of points given when calling create_row as example), which are then referenced in 2 different instances of Row. When restarting the the program, the rows are restored from a file, in which case, the list of points are instantiated seperately (fixing this shared reference).
The fix is to simply change the function to explicitly create a new list, when no argument is supplied.