Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crop-Type for Beds Handling and Selected Bed Fixing #230

Merged
merged 36 commits into from
Dec 5, 2024
Merged

Conversation

LukasBaecker
Copy link
Contributor

@LukasBaecker LukasBaecker commented Nov 14, 2024

This PR adds the functionality to add a crop-type for a field or its individual beds. Also, it adapts the field_navigation along with these crop types.
Furthermore, the ability to deselect beds for navigation (added with PR #219) needs to be fixed, due to small issues. Along with this the field_provider will be cleaned-up, due to triggering events multiple times at some points.

  • adding crops to field and row
  • add crop-setup (changing) to field_creator, operation and field_provider
  • fixing selected beds
  • cleaning field_provider
  • write tests
  • test on a robot

@LukasBaecker LukasBaecker added the enhancement New feature or request label Nov 18, 2024
@LukasBaecker LukasBaecker added this to the 0.7.0 milestone Nov 18, 2024
@LukasBaecker
Copy link
Contributor Author

The bed selection has been fixed in #237

@LukasBaecker LukasBaecker marked this pull request as ready for review November 27, 2024 16:20
Copy link
Contributor

@pascalzauberzeug pascalzauberzeug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good for now.
The field settings could be more elegant, but I think that can wait until the next big ui overhaul

@LukasBaecker LukasBaecker merged commit 8eac021 into main Dec 5, 2024
2 checks passed
@LukasBaecker LukasBaecker deleted the crops_per_bed branch December 5, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants