code review

zauberzeug · Jul 18, 2024 · 8432a59 · 8432a59
1 parent f79de9e
commit 8432a59
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/nicegui/element_filter.py b/nicegui/element_filter.py
@@ -63,7 +63,7 @@ def _iterate(self, parent: Element, *, visited: Optional[List[Element]] = None)
                 (element.source if isinstance(element, SourceElement) else ''),
                 element._props.get('placeholder', ''),
                 (element._props.get('value', '') or ''),  # NOTE the value could be None
-                element._props.get('options', {}).get('message', '')
+                element._props.get('options', {}).get('message', ''),
             ]
             content = ' '.join(str(c) for c in element_contents)
 

diff --git a/nicegui/elements/notification.py b/nicegui/elements/notification.py
@@ -1,5 +1,5 @@
 import asyncio
-from typing import Any, Callable, Literal, Optional, Union
+from typing import Any, Callable, Dict, Literal, Optional, Union
 
 from typing_extensions import Self
 
@@ -41,7 +41,7 @@ def __init__(self,
                  spinner: bool = False,
                  timeout: Optional[float] = 5.0,
                  on_dismiss: Optional[Callable] = None,
-                 options: Optional[dict] = None,
+                 options: Optional[Dict] = None,
                  **kwargs: Any,
                  ) -> None:
         """Notification element

diff --git a/nicegui/static/nicegui.js b/nicegui/static/nicegui.js
@@ -345,7 +345,6 @@ function createApp(elements, options) {
           window.open(url, target);
         },
         download: (msg) => download(msg.src, msg.filename, msg.media_type, options.prefix),
-        notify: (msg) => Quasar.Notify.create(msg),
       };
       const socketMessageQueue = [];
       let isProcessingSocketMessage = false;