Remove hardcoded z-up for scene orbit controls

zauberzeug · Aug 20, 2024 · 8c80453 · 8c80453
1 parent be557ff
commit 8c80453
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/nicegui/elements/scene.js b/nicegui/elements/scene.js
@@ -85,7 +85,7 @@ export default {
     }
     this.look_at = new THREE.Vector3(0, 0, 0);
     this.camera.lookAt(this.look_at);
-    this.camera.up = new THREE.Vector3(0, 0, 1);
+    this.camera.up = new THREE.Vector3(this.camera_up[0], this.camera_up[1], this.camera_up[2]);
     this.camera.position.set(0, -3, 5);
 
     this.scene.add(new THREE.AmbientLight(0xffffff, 0.7 * Math.PI));

diff --git a/nicegui/elements/scene.py b/nicegui/elements/scene.py
@@ -106,6 +106,7 @@ def __init__(self,
         self.camera = camera or self.perspective_camera()
         self._props['camera_type'] = self.camera.type
         self._props['camera_params'] = self.camera.params
+        self._props['camera_up'] = [self.camera.up_x, self.camera.up_y, self.camera.up_z]
         self.objects: Dict[str, Object3D] = {}
         self.stack: List[Union[Object3D, SceneObject]] = [SceneObject()]
         self._click_handlers = [on_click] if on_click else []