JavaScript error when using ui.notify

[falkoschindler]

Description

A simple example like

ui.button('Notify', on_click=lambda: ui.notify('Hi!'))

causes a JavaScript error when pressing the button twice or when resizing the window while a notification is visible:

quasar.umd.prod.js:6 Notify: trying to update a grouped one which is forbidden {message: 'Hi!', position: 'bottom', closeBtn: 'OK', multiLine: false, onDismiss: ƒ}

What is happening? 🤔

[falkoschindler]

Bisection shows that this bug has been introduced by PR #3121.
I'll try to further narrow it down, since this PR is quite a monster.

[falkoschindler]

Ok, commit 8b519dc causes the bug, mainly
8b519dc#diff-2e7a902681849d4a8afbb7f3bb101fb145be4f0c2e07a62c15ff9a928b8bc4a7 and
8b519dc#diff-629641010f936f1579dd98418afd8f861c14e90c098535245d208dce5eef034a.

[falkoschindler]

This if condition in notification.js might do the trick:

  updated() {
    if (this.convertedOptions.group === False) this.notification();
  },

But I noticed that if you try to dismiss a grouped notification (indicated by a red badge in its top left corner), there are UI elements remaining in memory:

ui.button('Notify', on_click=lambda: ui.notify('Hi!', close_button='Close'))
ui.timer(1, lambda: print(len(ui.context.client.elements)))

This might be a separate bug, but seems to be caused by the same commit.