Fix JavaScript error caused by new ui.notify
#3457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the JavaScript error and memory leak reported in #3454 when using
ui.notify, which creates aui.notificationelements since PR #3121.As it turned out, there is an important difference between
ui.notifyandui.notificationwhich is why this PR revertsui.notifyback to calling a Quasar function instead of creating an element:ui.notifyallows grouping of multiple identical notifications, whileui.notificationcreates new popups each time. Therefore it is impractical to replace one with another, causing errors and memory leaks.Besides reverting
ui.notify, this PR introduces a newUserNotifyclass to simulate notifications forusertests. It doesn't simulate durations or dismiss buttons - the notifications simply remain "visible" -, but that should be ok for now and can be extended later.