Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically hide ui.code's copy button #2288

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Dynamically hide ui.code's copy button #2288

merged 1 commit into from
Jan 5, 2024

Conversation

falkoschindler
Copy link
Contributor

Inspired by GitHub's code blocks, this PR hides the copy button of ui.code when scrolling. A timer is used to show the button after 1 second of inactivity.

Can be tested with something like

ui.code('print("This is a very long line.")').classes('w-32')

@falkoschindler falkoschindler added the enhancement New feature or request label Jan 5, 2024
@falkoschindler falkoschindler added this to the 1.4.9 milestone Jan 5, 2024
@falkoschindler falkoschindler linked an issue Jan 5, 2024 that may be closed by this pull request
ui.code copy button inside ui.card dialog overlaps content #2283
Closed
@falkoschindler falkoschindler mentioned this pull request Jan 5, 2024
Closed
@rodja rodja merged commit 5c195b5 into main Jan 5, 2024
7 checks passed
@rodja rodja deleted the copy-button branch January 5, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodja rodja rodja approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4.9
Development

Successfully merging this pull request may close these issues.

ui.code copy button inside ui.card dialog overlaps content
2 participants
@falkoschindler @rodja