Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce update_from_pandas method for ui.table #3264

Closed
wants to merge 1 commit into from

Conversation

tmlmt
Copy link
Contributor

@tmlmt tmlmt commented Jun 22, 2024

Resolves: #2731

Opening this PR as draft to request a check as to whether this is going in the right direction.

Principles followed:

  • In order to reuse the part of the code which checks the DataFrame and potentially casts into string the special types, took it out of the from_pandas method and even out of the class to avoid it being confused with a class method. Alternative is to keep it in the class with one or two leading underscores in the name.
  • Only expect a DataFrame to be given as parameter, the rest can be updated manually relatively easily (I though intend to update this PR if you accept the introduction of Allow pandas DataFrame df and rows as two sources of rows, make columns optional, and introduce default column config #3263 which enables a finer grain of definition of the columns upon calling the function). Alternative is to accept some of same other parameters as in from_pandas

@rodja rodja added the enhancement New feature or request label Jun 22, 2024
@tmlmt tmlmt marked this pull request as draft June 22, 2024 06:40
@falkoschindler
Copy link
Contributor

This feature has been developed further in PR #3525 and will be released shortly in version 2.0.0.
Therefore I'll close this pull request.

@falkoschindler falkoschindler added this to the 2.0.0 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants