Reserve bottom space for error message #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodja
approved these changes
Aug 6, 2024
falkoschindler
added a commit
that referenced
this pull request
Aug 6, 2024
This reverts commit d405d0d.
falkoschindler
added a commit
that referenced
this pull request
Aug 6, 2024
rodja
pushed a commit
that referenced
this pull request
Aug 12, 2024
* use "exposes_libraries" instead of "libraries" * use "exposes_libraries" instead of "extra_libraries" * add example "signature-pad" on how to use npm dependencies * try to create example with npm and webpack * fix import * reserve bottom space for error message (#3446) * Revert "reserve bottom space for error message (#3446)" This reverts commit d405d0d. * fix is_even example * introduce `dependencies` parameter * improve READMEs * add new examples to examples.py * add section about custom components to the documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the previous discussions in #2484, #2492, #2738, and #3013 to initialize the "error" prop of validation elements to avoid them to resize when error messages appear while typing.
Demonstration:
The bottom space is right there when loading the page.