Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix intersection of parallel line segments #225

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fix intersection of parallel line segments #225

merged 1 commit into from
Nov 5, 2024

Conversation

falkoschindler
Copy link
Contributor

When intersecting two parallel line segments, e.g. (0, 0)--(1, 0) and (0, 1)--(1, 1), the determinant d becomes zero and the division is undefined. We should return None in this case.

@falkoschindler falkoschindler added the bug Something isn't working label Nov 5, 2024
@falkoschindler falkoschindler added this to the 0.19.0 milestone Nov 5, 2024
pascalzauberzeug
pascalzauberzeug approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@pascalzauberzeug pascalzauberzeug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@pascalzauberzeug pascalzauberzeug merged commit ca26eb1 into main Nov 5, 2024
7 checks passed
@pascalzauberzeug pascalzauberzeug deleted the line-intersection branch November 5, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalzauberzeug pascalzauberzeug pascalzauberzeug approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@falkoschindler @pascalzauberzeug