Add type annotation and kwargs to run.io_bound
and run.cpu_bound
#227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed by @denniswittich, IO- and CPU-bound functions in RoSys are missing type annotations for parameters and return values. Apart from that
run.cpu_bound
is missingkwargs
.While this PR adds both, it unveils several type errors in connection with
run.cpu_bound
andrun.io_bound
:We should fix them before merging into main.