feat(parser): adjust scope parsing (without braces)

zauni · Feb 1, 2024 · 59db7f4 · 59db7f4
1 parent 91940d2
commit 59db7f4
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 14 deletions.
diff --git a/src/commit.pest b/src/commit.pest
@@ -1,10 +1,11 @@
 commit = { SOI ~ header ~ body? ~ footer? ~ EOI }
 
-header = ${ commit_type ~ scope? ~ "!"? ~ ":" ~ WHITE_SPACE+ ~ subject }
+header = ${ commit_type ~ scope_with_braces? ~ "!"? ~ ":" ~ WHITE_SPACE+ ~ subject }
 
 commit_type = @{ ASCII_ALPHANUMERIC+ }
 
-scope = @{ "(" ~ ASCII_ALPHANUMERIC+ ~ ")" }
+scope = @{ ASCII_ALPHANUMERIC+ }
+scope_with_braces = _{ "(" ~ scope ~ ")" }
 
 subject = @{ text_without_newline }
 

diff --git a/src/parser.rs b/src/parser.rs
@@ -174,6 +174,11 @@ mod tests {
                 commit: String::from("feat: add cool feature\nsome body"),
                 want_err: true,
             },
+            TestConfig {
+                name: String::from("random text"),
+                commit: String::from("Added a cool new feature"),
+                want_err: true,
+            },
         ];
 
         for test_config in test_configs {

diff --git a/src/snapshots/commitlint_rs__parser__tests__body and footer missing.snap b/src/snapshots/commitlint_rs__parser__tests__body and footer missing.snap
@@ -13,9 +13,9 @@ commit_type:
   start: 0
   end: 4
 scope:
-  input: (nice)
-  start: 4
-  end: 10
+  input: nice
+  start: 5
+  end: 9
 subject:
   input: add cool feature
   start: 12

diff --git a/src/snapshots/commitlint_rs__parser__tests__breaking change after scope.snap b/src/snapshots/commitlint_rs__parser__tests__breaking change after scope.snap
@@ -16,9 +16,9 @@ commit_type:
   start: 0
   end: 4
 scope:
-  input: (nice)
-  start: 4
-  end: 10
+  input: nice
+  start: 5
+  end: 9
 subject:
   input: add cool feature
   start: 13

diff --git a/src/snapshots/commitlint_rs__parser__tests__complex.snap b/src/snapshots/commitlint_rs__parser__tests__complex.snap
@@ -19,9 +19,9 @@ commit_type:
   start: 0
   end: 4
 scope:
-  input: (nice)
-  start: 4
-  end: 10
+  input: nice
+  start: 5
+  end: 9
 subject:
   input: add cool feature
   start: 12

diff --git a/src/snapshots/commitlint_rs__parser__tests__footer missing.snap b/src/snapshots/commitlint_rs__parser__tests__footer missing.snap
@@ -16,9 +16,9 @@ commit_type:
   start: 0
   end: 4
 scope:
-  input: (nice)
-  start: 4
-  end: 10
+  input: nice
+  start: 5
+  end: 9
 subject:
   input: add cool feature
   start: 12