build: add more checks and fix clippy hints

.github/workflows/ci.yml

@@ -1,22 +1,23 @@
-name: Rust
+name: CI
 
 on:
   push:
-    branches: [ "main" ]
+    branches: ["*"]
   pull_request:
-    branches: [ "main" ]
+    branches: ["main"]
 
 env:
   CARGO_TERM_COLOR: always
 
 jobs:
   build:
-
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v3
-    - name: Build
-      run: cargo build --verbose
-    - name: Run tests
-      run: cargo test --verbose
+      - uses: actions/checkout@v3
+      - name: Build
+        run: cargo build --verbose
+      - name: Lint
+        run: cargo clippy && cargo fmt --check
+      - name: Run tests
+        run: cargo test --verbose

src/main.rs

@@ -1,7 +1,12 @@
 mod parser;
 mod rules;
 
-use std::{env::current_dir, io::{stdin, Read}, path::PathBuf, process::ExitCode};
+use std::{
+    env::current_dir,
+    io::{stdin, Read},
+    path::PathBuf,
+    process::ExitCode,
+};
 
 use clap::Parser;
 use miette::GraphicalReportHandler;

src/parser.rs

@@ -1,3 +1,5 @@
+use std::fmt;
+
 use serde::Serialize;
 
 use pest::{Parser, Span};
@@ -28,10 +30,6 @@ impl<'a> CommitSpan<'a> {
         }
     }
 
-    pub fn to_string(&self) -> String {
-        self.input.to_string()
-    }
-
     pub fn start(&self) -> usize {
         self.start
     }
@@ -41,6 +39,12 @@ impl<'a> CommitSpan<'a> {
     }
 }
 
+impl fmt::Display for CommitSpan<'_> {
+    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+        write!(f, "{}", self.input)
+    }
+}
+
 #[derive(Debug, Serialize)]
 pub struct Commit<'a> {
     /// The complete header of the commit message including the type, scope and subject
@@ -94,44 +98,39 @@ pub fn parse_commit(commit_msg: &str) -> Commit {
     };
 
     for pair in pairs {
-        match pair.as_rule() {
-            Rule::commit => {
-                commit.raw = pair.as_str().to_string();
-
-                for inner_pair in pair.into_inner() {
-                    match inner_pair.as_rule() {
-                        Rule::header => {
-                            commit.header = CommitSpan::from(inner_pair.as_span());
-
-                            for header_pair in inner_pair.into_inner() {
-                                match header_pair.as_rule() {
-                                    Rule::commit_type => {
-                                        commit.commit_type = CommitSpan::from(header_pair.as_span())
-                                    }
-                                    Rule::scope => {
-                                        commit.scope = Some(CommitSpan::from(header_pair.as_span()))
-                                    }
-                                    Rule::subject => {
-                                        commit.subject = CommitSpan::from(header_pair.as_span())
-                                    }
-                                    _ => {}
+        if let Rule::commit = pair.as_rule() {
+            commit.raw = pair.as_str().to_string();
+
+            for inner_pair in pair.into_inner() {
+                match inner_pair.as_rule() {
+                    Rule::header => {
+                        commit.header = CommitSpan::from(inner_pair.as_span());
+
+                        for header_pair in inner_pair.into_inner() {
+                            match header_pair.as_rule() {
+                                Rule::commit_type => {
+                                    commit.commit_type = CommitSpan::from(header_pair.as_span())
                                 }
+                                Rule::scope => {
+                                    commit.scope = Some(CommitSpan::from(header_pair.as_span()))
+                                }
+                                Rule::subject => {
+                                    commit.subject = CommitSpan::from(header_pair.as_span())
+                                }
+                                _ => {}
                             }
                         }
-                        Rule::body => commit.body = Some(CommitSpan::from(inner_pair.as_span())),
-                        Rule::footer => {
-                            commit.footer = Some(CommitSpan::from(inner_pair.as_span()))
-                        }
-                        Rule::commit_type => {
-                            commit.commit_type = CommitSpan::from(inner_pair.as_span())
-                        }
-                        Rule::scope => commit.scope = Some(CommitSpan::from(inner_pair.as_span())),
-                        Rule::subject => commit.subject = CommitSpan::from(inner_pair.as_span()),
-                        _ => {}
                     }
+                    Rule::body => commit.body = Some(CommitSpan::from(inner_pair.as_span())),
+                    Rule::footer => commit.footer = Some(CommitSpan::from(inner_pair.as_span())),
+                    Rule::commit_type => {
+                        commit.commit_type = CommitSpan::from(inner_pair.as_span())
+                    }
+                    Rule::scope => commit.scope = Some(CommitSpan::from(inner_pair.as_span())),
+                    Rule::subject => commit.subject = CommitSpan::from(inner_pair.as_span()),
+                    _ => {}
                 }
             }
-            _ => {}
         }
     }
 
@@ -170,7 +169,9 @@ mod tests {
                 want_err: false,
             },
             TestConfig {
-                name: String::from("body and footer missing with newline at the end (stdio input adds a newline)"),
+                name: String::from(
+                    "body and footer missing with newline at the end (stdio input adds a newline)",
+                ),
                 commit: String::from("feat(nice): add cool feature\n"),
                 want_err: false,
             },

src/rules/mod.rs

@@ -92,8 +92,8 @@ struct RulesDetails {
     scope_enum: EnumOpts,
     #[serde(rename = "scope-max-length")]
     scope_max_length: LengthOpts,
-    #[serde(rename = "scope-case")]
-    scope_case: CaseOpts,
+    // #[serde(rename = "scope-case")]
+    // scope_case: CaseOpts,
 }
 
 /// Config