Added vRY-Configurator

[tanishqmanuja]

• Used InquirerPy package
• Can be called using cmd using "vry.exe --configure" or "python main.py --configure" while development

[OwOHamper]

otherwise LGTM, not tested

[zayKenyon]

Firstly, I ran vRY with no issue. Used the advanced config, applied the default value for PORT by simply hitting ENTER when prompted for a number; re-ran vRY to be greeted with the Firewall error message.

[tanishqmanuja]

Will look into it today and update the PR.

[tanishqmanuja]

Works fine for me now .. has anyone tested after recent commit?

[OwOHamper]

What about my review?

[tanishqmanuja]

What about my review?

Fixed that problem.. its was due to string instead of int in port.

[tanishqmanuja]

@OwOHamper, Have you made your review public.. only one review is showing here.

[OwOHamper]

hmmm I am not sure

[tanishqmanuja]

Your review wasn't published ig.. cannot see it still on GitHub but image will do. Will push new commit for the suggestions

[OwOHamper]

You got any idea how I can publish it? lol

[tanishqmanuja]

Same thing happened with decrypt so he can help . I never reviewed any PR myself so i cant help :(

[tanishqmanuja]

Done refactoring. Plus since table mod PR is closed, can you remove this(pretty table from main.py) from source as it is unused now.

[OwOHamper]

it would still break you would need to create double if statement because it would check both values and if sys.argv[1] is undefined the first condition would be False but second one would still be checked. And also in the bare except you should print what exactly went wrong or initialize logs before it and log it. If there was some error we wouldn't have idea what it is

[tanishqmanuja]

it would still break you would need to create double if statement because it would check both values and if sys.argv[1] is undefined the first condition would be False but second one would still be checked. And also in the bare except you should print what exactly went wrong or initialize logs before it and log it. If there was some error we wouldn't have idea what it is

AFAIK and operator is short-circuited in python and javascript that means second condition is only evaluated if first is true so double if is not required. I have tested calling main.py with and without arguments and both cases have worked.
As for the bare except, you are right about the situation but I being a js dev have little to no knowledge about the exceptions in python .. will need your help on that.

[D3CRYPT360]

You got any idea how I can publish it? lol

[zayKenyon]

Handling the input of no for proceed under src/configuator.py would lead to a better UX since it currently throws an error.