Skip to content

Commit

Permalink
Cleanup some code leftovers from a previous refactor (kubernetes-sigs…
Browse files Browse the repository at this point in the history
  • Loading branch information
zcahana committed Nov 9, 2020
1 parent 9f0367a commit ac788de
Showing 1 changed file with 6 additions and 20 deletions.
26 changes: 6 additions & 20 deletions pkg/predicate/predicate.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,21 +122,14 @@ type ResourceVersionChangedPredicate struct {
// Update implements default UpdateEvent filter for validating resource version change
func (ResourceVersionChangedPredicate) Update(e event.UpdateEvent) bool {
if e.ObjectOld == nil {
log.Error(nil, "UpdateEvent has no old metadata", "event", e)
return false
}
if e.ObjectOld == nil {
log.Error(nil, "GenericEvent has no old runtime object to update", "event", e)
log.Error(nil, "Update event has no old object to update", "event", e)
return false
}
if e.ObjectNew == nil {
log.Error(nil, "GenericEvent has no new runtime object for update", "event", e)
return false
}
if e.ObjectNew == nil {
log.Error(nil, "UpdateEvent has no new metadata", "event", e)
log.Error(nil, "Update event has no new object to update", "event", e)
return false
}

return e.ObjectNew.GetResourceVersion() != e.ObjectOld.GetResourceVersion()
}

Expand All @@ -163,21 +156,14 @@ type GenerationChangedPredicate struct {
// Update implements default UpdateEvent filter for validating generation change
func (GenerationChangedPredicate) Update(e event.UpdateEvent) bool {
if e.ObjectOld == nil {
log.Error(nil, "Update event has no old metadata", "event", e)
return false
}
if e.ObjectOld == nil {
log.Error(nil, "Update event has no old runtime object to update", "event", e)
log.Error(nil, "Update event has no old object to update", "event", e)
return false
}
if e.ObjectNew == nil {
log.Error(nil, "Update event has no new runtime object for update", "event", e)
return false
}
if e.ObjectNew == nil {
log.Error(nil, "Update event has no new metadata", "event", e)
log.Error(nil, "Update event has no new object for update", "event", e)
return false
}

return e.ObjectNew.GetGeneration() != e.ObjectOld.GetGeneration()
}

Expand Down

0 comments on commit ac788de

Please sign in to comment.