Implement Sinsemilla #164

therealyingtong · 2021-02-02T14:02:20Z

Closes #73.

TODOs:

Decide how to constrain (x_q, y_q) (the point used to initialise the hash) in the circuit. We could introduce a custom gate but that's rather a waste of a fixed column.
Decide on personalisation input to generate Q.

codecov-io · 2021-02-05T07:55:46Z

Codecov Report

Merging #164 (04e95cc) into main (c5c0dbe) will increase coverage by 1.94%.
The diff coverage is 88.94%.

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   81.12%   83.07%   +1.94%     
==========================================
  Files          44       47       +3     
  Lines        4721     4915     +194     
==========================================
+ Hits         3830     4083     +253     
+ Misses        891      832      -59

Impacted Files	Coverage Δ
src/gadget/sinsemilla/chip/generator_table.rs	`84.44% <84.44%> (ø)`
src/gadget/sinsemilla/chip.rs	`87.71% <87.71%> (ø)`
src/gadget/sinsemilla.rs	`100.00% <100.00%> (ø)`
src/plonk/prover.rs	`99.55% <0.00%> (+<0.01%)`	⬆️
src/plonk/lookup/prover.rs	`90.84% <0.00%> (+1.46%)`	⬆️
src/plonk/keygen.rs	`95.83% <0.00%> (+1.46%)`	⬆️
src/plonk/circuit.rs	`64.87% <0.00%> (+1.95%)`	⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c0dbe...04e95cc. Read the comment docs.

src/gadget/sinsemilla.rs

src/gadget/sinsemilla/chip.rs

therealyingtong · 2021-02-26T10:58:05Z

Superseded by zcash/orchard#24 and zcash/orchard#25.

[book] decomposition.md: avoid introducing `m` when we already have `range`

* add a constructor * add more comment * fix as review * remove clone * remove * no need to use new variable * change comment * fix clippy * rename to from_parts * remove n declaration

therealyingtong added this to the Core Sprint 2021-04 milestone Feb 2, 2021

therealyingtong marked this pull request as draft February 3, 2021 01:26

therealyingtong force-pushed the sinsemilla branch from eb80822 to 771a16f Compare February 5, 2021 07:12

therealyingtong changed the base branch from main to sinsemilla-base February 5, 2021 07:12

therealyingtong force-pushed the sinsemilla branch from 771a16f to 8220a87 Compare February 5, 2021 07:33

therealyingtong force-pushed the sinsemilla branch 2 times, most recently from 909b3da to cd240cd Compare February 9, 2021 05:21

therealyingtong force-pushed the sinsemilla-base branch from 152938a to 1a9fa98 Compare February 11, 2021 09:16

therealyingtong force-pushed the sinsemilla branch from cd240cd to 3b94170 Compare February 11, 2021 09:17

therealyingtong force-pushed the sinsemilla-base branch from 1a9fa98 to 77b510f Compare February 13, 2021 15:55

therealyingtong force-pushed the sinsemilla branch from 3b94170 to c397890 Compare February 13, 2021 15:55

therealyingtong force-pushed the sinsemilla-base branch from 77b510f to e70b23c Compare February 14, 2021 00:57

therealyingtong force-pushed the sinsemilla branch 2 times, most recently from b56487f to 64b3a7f Compare February 14, 2021 01:06

therealyingtong force-pushed the sinsemilla-base branch from e70b23c to e06a0d9 Compare February 14, 2021 15:26

therealyingtong force-pushed the sinsemilla branch from 64b3a7f to 7b7a199 Compare February 14, 2021 15:26

therealyingtong changed the title ~~[WIP] Implement Sinsemilla~~ Implement Sinsemilla Feb 14, 2021

therealyingtong marked this pull request as ready for review February 14, 2021 15:27

therealyingtong force-pushed the sinsemilla-base branch from e06a0d9 to 47cb868 Compare February 15, 2021 06:34

therealyingtong force-pushed the sinsemilla branch from 7b7a199 to e7edfa8 Compare February 15, 2021 06:34

r3ld3v modified the milestones: Core Sprint 2021-04, Core Sprint 2021-06 Feb 15, 2021

therealyingtong force-pushed the sinsemilla-base branch from 47cb868 to 63614a0 Compare February 15, 2021 16:57

therealyingtong force-pushed the sinsemilla branch from e7edfa8 to 87322ef Compare February 15, 2021 16:57

therealyingtong force-pushed the sinsemilla-base branch from 63614a0 to d8314db Compare February 16, 2021 09:40

therealyingtong force-pushed the sinsemilla branch 2 times, most recently from 90a0ffa to a267434 Compare February 16, 2021 13:38

therealyingtong force-pushed the sinsemilla-base branch from d8314db to b03f7d5 Compare February 18, 2021 10:22

therealyingtong force-pushed the sinsemilla branch from 204b2f2 to de804ad Compare February 18, 2021 10:23

nuttycom requested changes Feb 18, 2021

View reviewed changes

therealyingtong force-pushed the sinsemilla-base branch from b03f7d5 to 7d96ea2 Compare February 20, 2021 15:00

therealyingtong force-pushed the sinsemilla branch from de804ad to e28e776 Compare February 20, 2021 15:00

therealyingtong force-pushed the sinsemilla-base branch from 7d96ea2 to e408a35 Compare February 22, 2021 12:20

therealyingtong force-pushed the sinsemilla branch 2 times, most recently from 44dceda to 0277175 Compare February 22, 2021 12:22

Add Sinsemilla gadget

414eecd

therealyingtong force-pushed the sinsemilla branch from 0277175 to fb919a8 Compare February 23, 2021 02:05

therealyingtong changed the base branch from sinsemilla-base to main February 23, 2021 02:05

therealyingtong force-pushed the sinsemilla branch 2 times, most recently from 63ca2ec to 7e34f7c Compare February 23, 2021 02:27

therealyingtong added 5 commits February 23, 2021 23:26

Add Sinsemilla chip and generator_table

62a06f2

Add Sinsemilla gate

9ce8430

Assign cells

87d6f47

Add Sinsemilla test

d3519ee

Further type cleanups

04e95cc

therealyingtong force-pushed the sinsemilla branch from eb2ecfa to 04e95cc Compare February 23, 2021 15:37

therealyingtong closed this Feb 26, 2021

str4d deleted the sinsemilla branch February 26, 2021 11:37

str4d added a commit that referenced this pull request Jan 19, 2022

Merge pull request #164 from daira/book-decomposition

a273307

[book] decomposition.md: avoid introducing `m` when we already have `range`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Sinsemilla #164

Implement Sinsemilla #164

therealyingtong commented Feb 2, 2021 •

edited

Loading

codecov-io commented Feb 5, 2021 •

edited

Loading

therealyingtong commented Feb 26, 2021

Implement Sinsemilla #164

Implement Sinsemilla #164

Conversation

therealyingtong commented Feb 2, 2021 • edited Loading

codecov-io commented Feb 5, 2021 • edited Loading

Codecov Report

therealyingtong commented Feb 26, 2021

therealyingtong commented Feb 2, 2021 •

edited

Loading

codecov-io commented Feb 5, 2021 •

edited

Loading