Skip to content

halo2_proofs: Pin dev-dependencies to versions compatible with MSRV

Sign in for the full log view
GitHub Actions / Clippy (beta) succeeded Jul 30, 2023 in 2s

Clippy (beta)

139 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 139
Note 0
Help 0

Versions

  • rustc 1.72.0-beta.3 (a47f796a3 2023-07-22)
  • cargo 1.72.0-beta.3 (dd6536b8e 2023-07-18)
  • clippy 0.1.72 (a47f796 2023-07-22)

Annotations

Check warning on line 1066 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Iterator::fold` on a type that implements `Try`

warning: usage of `Iterator::fold` on a type that implements `Try`
    --> halo2_proofs/src/dev.rs:1066:30
     |
1066 | ...                   .fold(Ok(()), |acc, res| acc.and(res))
     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold((), |acc, res| ...)`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
     = note: `-W clippy::manual-try-fold` implied by `-W clippy::all`

Check warning on line 414 in halo2_proofs/src/dev/cost.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> halo2_proofs/src/dev/cost.rs:414:33
    |
414 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 371 in halo2_proofs/src/dev/cost.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> halo2_proofs/src/dev/cost.rs:371:33
    |
371 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 328 in halo2_proofs/src/dev/cost.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> halo2_proofs/src/dev/cost.rs:328:33
    |
328 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 174 in halo2_proofs/src/poly.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/poly.rs:174:22
    |
174 |                 .zip(inv_denoms.into_iter())
    |                      ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/a47f796a36593d352d79ee66d7f4c12d100f5241/library/core/src/iter/traits/iterator.rs:641:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 159 in halo2_proofs/src/poly.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/poly.rs:159:14
    |
159 |         .zip(assigned_denominators.into_iter())
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/a47f796a36593d352d79ee66d7f4c12d100f5241/library/core/src/iter/traits/iterator.rs:641:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 447 in halo2_proofs/src/poly/multiopen.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/poly/multiopen.rs:447:41
    |
447 |             col_indices.into_iter().zip(point_indices.into_iter()).collect()
    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `point_indices`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/a47f796a36593d352d79ee66d7f4c12d100f5241/library/core/src/iter/traits/iterator.rs:641:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 105 in halo2_proofs/src/poly/multiopen/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/poly/multiopen/prover.rs:105:58
    |
105 |     let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold(
    |                                                          ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/a47f796a36593d352d79ee66d7f4c12d100f5241/library/core/src/iter/traits/iterator.rs:641:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 432 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Arc<T>` where `T` is not `Send` or `Sync`

warning: usage of `Arc<T>` where `T` is not `Send` or `Sync`
   --> halo2_proofs/src/poly/evaluator.rs:432:20
    |
432 |         Ast::Scale(Arc::new(self.clone()), other)
    |                    ^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider using `Rc<T>` instead or wrapping `T` in a std::sync type like `Mutex<T>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 424 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Arc<T>` where `T` is not `Send` or `Sync`

warning: usage of `Arc<T>` where `T` is not `Send` or `Sync`
   --> halo2_proofs/src/poly/evaluator.rs:424:20
    |
424 |         Ast::Scale(Arc::new(self), other)
    |                    ^^^^^^^^^^^^^^
    |
    = help: consider using `Rc<T>` instead or wrapping `T` in a std::sync type like `Mutex<T>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 416 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Arc<T>` where `T` is not `Send` or `Sync`

warning: usage of `Arc<T>` where `T` is not `Send` or `Sync`
   --> halo2_proofs/src/poly/evaluator.rs:416:41
    |
416 |         Ast::Mul(AstMul(Arc::new(self), Arc::new(other.into())))
    |                                         ^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider using `Rc<T>` instead or wrapping `T` in a std::sync type like `Mutex<T>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 416 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Arc<T>` where `T` is not `Send` or `Sync`

warning: usage of `Arc<T>` where `T` is not `Send` or `Sync`
   --> halo2_proofs/src/poly/evaluator.rs:416:25
    |
416 |         Ast::Mul(AstMul(Arc::new(self), Arc::new(other.into())))
    |                         ^^^^^^^^^^^^^^
    |
    = help: consider using `Rc<T>` instead or wrapping `T` in a std::sync type like `Mutex<T>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 398 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Arc<T>` where `T` is not `Send` or `Sync`

warning: usage of `Arc<T>` where `T` is not `Send` or `Sync`
   --> halo2_proofs/src/poly/evaluator.rs:398:41
    |
398 |         Ast::Mul(AstMul(Arc::new(self), Arc::new(other)))
    |                                         ^^^^^^^^^^^^^^^
    |
    = help: consider using `Rc<T>` instead or wrapping `T` in a std::sync type like `Mutex<T>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 398 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Arc<T>` where `T` is not `Send` or `Sync`

warning: usage of `Arc<T>` where `T` is not `Send` or `Sync`
   --> halo2_proofs/src/poly/evaluator.rs:398:25
    |
398 |         Ast::Mul(AstMul(Arc::new(self), Arc::new(other)))
    |                         ^^^^^^^^^^^^^^
    |
    = help: consider using `Rc<T>` instead or wrapping `T` in a std::sync type like `Mutex<T>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 390 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Arc<T>` where `T` is not `Send` or `Sync`

warning: usage of `Arc<T>` where `T` is not `Send` or `Sync`
   --> halo2_proofs/src/poly/evaluator.rs:390:41
    |
390 |         Ast::Mul(AstMul(Arc::new(self), Arc::new(other.into())))
    |                                         ^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider using `Rc<T>` instead or wrapping `T` in a std::sync type like `Mutex<T>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 390 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Arc<T>` where `T` is not `Send` or `Sync`

warning: usage of `Arc<T>` where `T` is not `Send` or `Sync`
   --> halo2_proofs/src/poly/evaluator.rs:390:25
    |
390 |         Ast::Mul(AstMul(Arc::new(self), Arc::new(other.into())))
    |                         ^^^^^^^^^^^^^^
    |
    = help: consider using `Rc<T>` instead or wrapping `T` in a std::sync type like `Mutex<T>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 374 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Arc<T>` where `T` is not `Send` or `Sync`

warning: usage of `Arc<T>` where `T` is not `Send` or `Sync`
   --> halo2_proofs/src/poly/evaluator.rs:374:41
    |
374 |         Ast::Mul(AstMul(Arc::new(self), Arc::new(other)))
    |                                         ^^^^^^^^^^^^^^^
    |
    = help: consider using `Rc<T>` instead or wrapping `T` in a std::sync type like `Mutex<T>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 374 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Arc<T>` where `T` is not `Send` or `Sync`

warning: usage of `Arc<T>` where `T` is not `Send` or `Sync`
   --> halo2_proofs/src/poly/evaluator.rs:374:25
    |
374 |         Ast::Mul(AstMul(Arc::new(self), Arc::new(other)))
    |                         ^^^^^^^^^^^^^^
    |
    = help: consider using `Rc<T>` instead or wrapping `T` in a std::sync type like `Mutex<T>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 342 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Arc<T>` where `T` is not `Send` or `Sync`

warning: usage of `Arc<T>` where `T` is not `Send` or `Sync`
   --> halo2_proofs/src/poly/evaluator.rs:342:34
    |
342 |         Ast::Add(Arc::new(self), Arc::new(other.into()))
    |                                  ^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider using `Rc<T>` instead or wrapping `T` in a std::sync type like `Mutex<T>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 342 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Arc<T>` where `T` is not `Send` or `Sync`

warning: usage of `Arc<T>` where `T` is not `Send` or `Sync`
   --> halo2_proofs/src/poly/evaluator.rs:342:18
    |
342 |         Ast::Add(Arc::new(self), Arc::new(other.into()))
    |                  ^^^^^^^^^^^^^^
    |
    = help: consider using `Rc<T>` instead or wrapping `T` in a std::sync type like `Mutex<T>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 326 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Arc<T>` where `T` is not `Send` or `Sync`

warning: usage of `Arc<T>` where `T` is not `Send` or `Sync`
   --> halo2_proofs/src/poly/evaluator.rs:326:34
    |
326 |         Ast::Add(Arc::new(self), Arc::new(other))
    |                                  ^^^^^^^^^^^^^^^
    |
    = help: consider using `Rc<T>` instead or wrapping `T` in a std::sync type like `Mutex<T>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 326 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Arc<T>` where `T` is not `Send` or `Sync`

warning: usage of `Arc<T>` where `T` is not `Send` or `Sync`
   --> halo2_proofs/src/poly/evaluator.rs:326:18
    |
326 |         Ast::Add(Arc::new(self), Arc::new(other))
    |                  ^^^^^^^^^^^^^^
    |
    = help: consider using `Rc<T>` instead or wrapping `T` in a std::sync type like `Mutex<T>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 310 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Arc<T>` where `T` is not `Send` or `Sync`

warning: usage of `Arc<T>` where `T` is not `Send` or `Sync`
   --> halo2_proofs/src/poly/evaluator.rs:310:20
    |
310 |         Ast::Scale(Arc::new(self), -F::ONE)
    |                    ^^^^^^^^^^^^^^
    |
    = help: consider using `Rc<T>` instead or wrapping `T` in a std::sync type like `Mutex<T>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 272 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Arc<T>` where `T` is not `Send` or `Sync`

warning: usage of `Arc<T>` where `T` is not `Send` or `Sync`
   --> halo2_proofs/src/poly/evaluator.rs:272:31
    |
272 |         Ast::DistributePowers(Arc::new(i.into_iter().collect()), base)
    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider using `Rc<T>` instead or wrapping `T` in a std::sync type like `Mutex<T>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
    = note: `-W clippy::arc-with-non-send-sync` implied by `-W clippy::all`

Check warning on line 124 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> halo2_proofs/src/poly/evaluator.rs:124:36
    |
124 |             _evaluator: PhantomData::default(),
    |                                    ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs